Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add test and improve examples for mpl_toolkits #23902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2022
Merged

Add test and improve examples for mpl_toolkits #23902

merged 2 commits into from
Sep 20, 2022

Conversation

oscargus
Copy link
Member

PR Summary

InsetPosition was untested and had an error in the example.

Add cross-reference to similar example not using mpl_toolkits.

Correct example as FloatingSubplot is no longer used.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added this to the v3.7.0 milestone Sep 16, 2022
@oscargus oscargus changed the title Add test and improve examples Add test and improve examples for mpl_toolkits Sep 16, 2022
@story645 story645 merged commit 6586784 into matplotlib:main Sep 20, 2022
@story645
Copy link
Member

story645 commented Sep 20, 2022 •
edited
Loading

am confused though why tests don't fall under bugfix type things and don't get milestoned against patches

@oscargus oscargus deleted the mpltoolkitsfixes branch September 20, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation topic: mpl_toolkit topic: testing
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oscargus @story645 @QuLogic