Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Display "dev" instead of "devdocs" in the version switcher #23949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2022
Merged

DOC: Display "dev" instead of "devdocs" in the version switcher #23949

merged 1 commit into from
Sep 19, 2022

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Sep 19, 2022 •
edited
Loading

This changes image to only show "dev".

While the url is devdocs historically, and I'm not going to change this, the displayed names should be "stable" and "dev". This has the added advantage that dev takes a little less space in the menubar, and thus wrapping occurs slightly later.

@timhoffm
DOC: Display "dev" instead of "devdocs" in the version switcher
816866d 
While the url is devdocs historically, and I'm not going to
change this, the displayed names should be "stable" and "dev".
This has the added advantage that dev takes a little less space
in the menubar, and thus wrapping occurs slightly later.
@timhoffm timhoffm added this to the v3.6-doc milestone Sep 19, 2022
story645
story645 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea if this needs 1 or 2 to merge

@jklymak jklymak merged commit b5fa310 into matplotlib:main Sep 19, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Sep 19, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b5fa31067e8e67e308b373285a68c44e9ca5efa8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #23949: DOC: Display "dev" instead of "devdocs" in the version switcher'
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-23949-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR #23949 on branch v3.6.x (DOC: Display "dev" instead of "devdocs" in the version switcher)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 19, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.0-doc
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b5fa31067e8e67e308b373285a68c44e9ca5efa8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #23949: DOC: Display "dev" instead of "devdocs" in the version switcher'
  1. Push to a named branch:
git push YOURFORK v3.6.0-doc:auto-backport-of-pr-23949-on-v3.6.0-doc
  1. Create a PR against branch v3.6.0-doc, I would have named this PR:

"Backport PR #23949 on branch v3.6.0-doc (DOC: Display "dev" instead of "devdocs" in the version switcher)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

QuLogic pushed a commit that referenced this pull request Sep 19, 2022
@jklymak @QuLogic
Merge pull request #23949 from timhoffm/version-switcher-dev
6578d9a 
DOC: Display "dev" instead of "devdocs" in the version switcher
(cherry picked from commit b5fa310)
@QuLogic
Copy link
Member

QuLogic commented Sep 19, 2022

Backported in #23942.

@QuLogic QuLogic modified the milestones: v3.6-doc, v3.6.1 Sep 19, 2022
@timhoffm timhoffm deleted the version-switcher-dev branch September 19, 2022 21:26
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Dec 19, 2022
@jklymak @melissawm
Merge pull request matplotlib#23949 from timhoffm/version-switcher-dev
bf42869 
DOC: Display "dev" instead of "devdocs" in the version switcher
(cherry picked from commit b5fa310)
@QuLogic QuLogic mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@timhoffm @QuLogic @story645 @jklymak