In usetex, remove vertical space inserted by TeX after displaymath. #24011
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Off topic: should I file a bug report for dvipng? (The author, coincidentally, is a colleague, currently my boss...) |
|
I don't think it's really a bug in dvipng, just a different definition of "baseline". OTOH one thing that we would look into is to use |
Should we return to the plan of reverting the original PR? |
|
Let's do that for now. |
|
The original PR was reverted, so I assume you'll just put this into 3.7. |
|
Yes. |
|
Moved to 3.8, but feel free to argue for a back port. |
|
No hurries, this still needs some work... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #23977. One can also check with the simpler example given at #23977 (comment).
Actually in the specific case of the eqnarray given in #23977 there would still seem to be an extra blank line at the bottom, but this is due to the extra
\\at the end of the eqnarray, which is now taken into account (... but not by dvipng apparently (*)); removing it (as shown in documented eqnarray examples, e.g. http://latexref.xyz/eqnarray.html, https://texfaq.org/FAQ-eqnarray) handles that.(*) but hopefully we'll get rid of dvipng anyways in favor of directly rendering the glyphs ourselves; see e.g. #22459 (comment).
Edit: no, that's not enough if the last line has nonzero descent. Back to the drawing board.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).