Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DOC]: adding a grid to the style sheet reference. #24020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 1, 2022
Merged

[DOC]: adding a grid to the style sheet reference. #24020

merged 6 commits into from
Oct 1, 2022

Conversation

kostyafarber
Copy link
Contributor

@kostyafarber kostyafarber commented Sep 27, 2022 •
edited
Loading

PR Summary

This PR adds gridlines to the last plot in the stylesheets example and adds an annotation ax.grid(True) as well as a divider to clearly distinguish between subplots. This addresses #23601

PR Checklist

Tests and Styling

  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

@kostyafarber kostyafarber marked this pull request as draft September 27, 2022 14:45
github-actions[bot]
github-actions bot reviewed Sep 27, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@kostyafarber kostyafarber reopened this Sep 27, 2022
@kostyafarber kostyafarber marked this pull request as ready for review September 27, 2022 15:08
@kostyafarber kostyafarber changed the title add divider and annotation. [DOC]: add divider and annotation. #23601 Sep 27, 2022
@kostyafarber kostyafarber changed the title [DOC]: add divider and annotation. #23601 [DOC]: add divider and annotation. Sep 27, 2022
@kostyafarber kostyafarber mentioned this pull request Sep 27, 2022
Closed
1 task
@kostyafarber
Copy link
Contributor Author

kostyafarber commented Sep 27, 2022 •
edited
Loading

Added @Kinza-Raza as co-author of commit.

jklymak
jklymak reviewed Sep 27, 2022
View reviewed changes
@QuLogic
Copy link
Member

QuLogic commented Sep 27, 2022

Please title the commit/PR correctly. You are adding a grid to the style sheet reference, not a divider and annotation. The latter is an implementation detail of the former.

@kostyafarber
Copy link
Contributor Author

No worries will change the PR title.

@kostyafarber kostyafarber changed the title [DOC]: add divider and annotation. [DOC]: adding a grid to the style sheet reference. Sep 28, 2022
@kostyafarber
Copy link
Contributor Author

@QuLogic changed the PR title.

@kostyafarber
Copy link
Contributor Author

@jklymak let me know if I need to do anything else. Thanks!

jklymak
jklymak reviewed Sep 30, 2022
View reviewed changes
jklymak
jklymak reviewed Sep 30, 2022
View reviewed changes
@jklymak
Copy link
Member

jklymak commented Oct 1, 2022

Thanks for your work and patience with this @kostyafarber . I think this looks good, and should be helpful for folks curious about what happens if they turn the grid on.

@jklymak jklymak merged commit fd5cf5c into matplotlib:main Oct 1, 2022
@kostyafarber kostyafarber deleted the issue-23601 branch October 2, 2022 16:00
@QuLogic QuLogic added this to the v3.7.0 milestone Oct 4, 2022
@QuLogic QuLogic mentioned this pull request Oct 4, 2022
Closed
Tortar pushed a commit to Tortar/matplotlib that referenced this pull request Oct 18, 2022
@kostyafarber @kinza-imran
@jklymak @Tortar
[DOC]: adding a grid to the style sheet reference. (matplotlib#24020)
bc73259 
* add divider and annotation.

Co-authored-by: Kinza Raza <[email protected]>

* fix flake8

* change from annotate to title

* Update examples/style_sheets/style_sheets_reference.py

Co-authored-by: Jody Klymak <[email protected]>

* Update examples/style_sheets/style_sheets_reference.py

Co-authored-by: Jody Klymak <[email protected]>

Co-authored-by: Kinza Raza <[email protected]>
Co-authored-by: Jody Klymak <[email protected]>
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Dec 19, 2022
@kostyafarber @kinza-imran
@jklymak @melissawm
[DOC]: adding a grid to the style sheet reference. (matplotlib#24020)
0063661 
* add divider and annotation.

Co-authored-by: Kinza Raza <[email protected]>

* fix flake8

* change from annotate to title

* Update examples/style_sheets/style_sheets_reference.py

Co-authored-by: Jody Klymak <[email protected]>

* Update examples/style_sheets/style_sheets_reference.py

Co-authored-by: Jody Klymak <[email protected]>

Co-authored-by: Kinza Raza <[email protected]>
Co-authored-by: Jody Klymak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kostyafarber @QuLogic @jklymak