Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reword SpanSelector example. #24032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Reword SpanSelector example. #24032

merged 1 commit into from
Sep 28, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 28, 2022

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight word nit, take or leave

@@ -3,9 +3,12 @@
Span Selector
=============

The SpanSelector is a mouse widget to select a xmin/xmax range and plot the
detail view of the selected region in the lower axes
The `.SpanSelector` is a mouse widget that allows selecting a range on an axis.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `.SpanSelector` is a mouse widget that allows selecting a range on an axis.
The `.SpanSelector` is a mouse widget that enables selecting a range on an axis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@oscargus oscargus merged commit 30e257c into matplotlib:main Sep 28, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 28, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 28, 2022
@anntzer anntzer deleted the ss branch September 28, 2022 17:51
timhoffm added a commit that referenced this pull request Sep 28, 2022
…032-on-v3.6.x

Backport PR #24032 on branch v3.6.x (Reword SpanSelector example.)
QuLogic added a commit that referenced this pull request Sep 28, 2022
…032-on-v3.6.0-doc

Backport PR #24032 on branch v3.6.0-doc (Reword SpanSelector example.)
@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants