Escape space after comma as decimal seperator #24079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Oct 3, 2022
| formatted = self.fix_minus(locale.format_string(fmt, (arg,), True) | ||
| if self._useLocale else fmt % arg) | ||
| if (self.get_useMathText()): # removed unintended space after comma | ||
| formatted = formatted.replace(',', '{,}') |
There was a problem hiding this comment.
This would incorrectly also escape commas actually present in fmt.
I guess a simple-ish solution could be to str.split fmt over commas, apply locale.format_string over each part, escape resulting commas over each formatted part, and join again using unescaped commas.
Edit: basically
return self.fix_minus(
# Escape commas introduced by format_string but not those present
# from the beginning in fmt.
",".join(locale.format_string(part, (arg,), True)
.replace(",", "{,}")
for part in fmt.split(","))
if self._useLocale else
fmt % arg)
anntzer
reviewed
Oct 21, 2022
| def test_locale_comma(): | ||
| import locale | ||
| currentLocale = locale.getlocale() | ||
| locale.setlocale(locale.LC_ALL, 'deu_deu') |
There was a problem hiding this comment.
This test will fail with "unsupported locale setting" if the locale is unavailable; at least this should be caught, and it may be better to just monkeypatch locale.format_string instead?
anntzer
requested changes
Oct 21, 2022
|
Moving to draft pending revision. @evanandresen anything we can do to help move this forward? |
This was referenced Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When creating a plot with a locale where a comma is used as the decimal seperator and with useMathText enabled for ticks, an unwanted space is added after the comma (Example: "3, 0"). This PR addresses this issue #23626 by adding an escape around the comma in a formatting method for the ticks.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).