Replace ClabelText by set_transform_rotates_text. #24140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
reviewed
Oct 11, 2022
| @@ -150,10 +151,8 @@ def clabel(self, levels=None, *, | |||
| or minus 90 degrees from level. | |||
|
|
|||
| use_clabeltext : bool, default: False | |||
There was a problem hiding this comment.
Should one consider renaming this argument?
oscargus
approved these changes
Oct 11, 2022
|
Let's defer that to another time. |
timhoffm
reviewed
Oct 11, 2022
| @@ -273,6 +272,7 @@ def get_label_width(self, lev, fmt, fsize): | |||
| width *= 72 / fig.dpi | |||
| return width | |||
|
|
|||
| @_api.deprecated("3.7", alternative="Artist.set") | |||
There was a problem hiding this comment.
The deprecation is a bit terse
I think
labeler.set_label_props(label, text, color)
is equivalent to
label.set(text=text, color=color, fontproperties=labeler.labelFontProps, clip_box(labeler.axes)
Which is not quite straight forward unless you check the source. Can we document this better (even only in the changelog would be ok).
timhoffm
approved these changes
Oct 12, 2022
ContourLabeler previously optionally used a custom Text subclass to ensure that text rotation took place in data space, not in screen space, but this is now available for all Text instances via the transform_rotates_text property, so directly use that. This means that _get_label_text, _add_label, and set_label_props can also directly get inlined into their now only callsite (add_label).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContourLabeler previously optionally used a custom Text subclass to ensure that text rotation took place in data space, not in screen space, but this is now available for all Text instances via the transform_rotates_text property, so directly use that. This means that _get_label_text, _add_label, and set_label_props can also directly get inlined into their now only callsite (add_label).
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).