Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST: convert nose-style tests #24173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2022
Merged

TST: convert nose-style tests #24173

merged 1 commit into from
Oct 15, 2022

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Oct 15, 2022

PR Summary

A minimal change to resolve #24148. Replaced Nose's setup with pytest's setup_method. I note that there is already an instance of setup_method within test_transforms.py. I installed pytest with

pip install git+https://github.com/pytest-dev/pytest.git@main

and verified that

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@timhoffm timhoffm merged commit ea9d195 into matplotlib:main Oct 15, 2022
@timhoffm
Copy link
Member

timhoffm commented Oct 15, 2022 •
edited
Loading

@meeseeksdev backport to v3.6.x

Not sure whether backporting is need, but better be on the safe side if pytest is releasing before matplotlib v3.7.

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 15, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 15, 2022
@timhoffm @meeseeksmachine
Backport PR matplotlib#24173: TST: convert nose-style tests
300a612
@timhoffm timhoffm added this to the v3.6.2 milestone Oct 15, 2022
@rcomer rcomer deleted the purge-nose-tests branch October 15, 2022 13:41
oscargus added a commit that referenced this pull request Oct 15, 2022
@oscargus
Merge pull request #24180 from meeseeksmachine/auto-backport-of-pr-24…
93d12a6 
…173-on-v3.6.x

Backport PR #24173 on branch v3.6.x (TST: convert nose-style tests)
@rcomer
Copy link
Member Author

rcomer commented Oct 16, 2022

For completeness, the real work to convert these tests was done some time ago, but I guess nose2pytest missed the setup method. #7318, #7883

@tacaswell
Copy link
Member

Thank you @rcomer ! I'm glad the fix here was straight forward.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Dec 8, 2022
@bmwiedemann
Update python-matplotlib to version 3.5.3 / rev 97 via SR 1041050
6305ed1 
https://build.opensuse.org/request/show/1041050
by user dgarcia + dimstar_suse
- Add fix-tests-pytest72.patch to fix tests failing with pytest 7.2
  gh#matplotlib/matplotlib#24173
@ksunden ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.2
Development

Successfully merging this pull request may close these issues.

remove nose-style test classes
4 participants
@rcomer @timhoffm @tacaswell @oscargus