Properly set and inherit backend_version. #24197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not really clear if we really need to keep the backend_version backend attribute, but currently it is getting overridden by _Backend.export to "unknown" (as can be checked e.g. by printing backend_agg.backend_version). Move the definition to within the _Backend class to fix that, and inherit that information where possible.
timhoffm
approved these changes
Oct 21, 2022
QuLogic
approved these changes
Oct 21, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 21, 2022
timhoffm
added a commit
that referenced
this pull request
Oct 21, 2022
…197-on-v3.6.x Backport PR #24197 on branch v3.6.x (Properly set and inherit backend_version.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not really clear if we really need to keep the backend_version backend attribute, but currently it is getting overridden by _Backend.export to "unknown" (as can be checked e.g. by printing backend_agg.backend_version). Move the definition to within the _Backend class to fix that, and inherit that information where possible.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).