-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix hatch linewidth in PGF #24263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix hatch linewidth in PGF #24263
Conversation
Not obvious why this kills all Linux tests, but no Windows or Mac tests. |
2acf945
to
7cbcd44
Compare
This looks extremely fragile. After a rebase I get even more errors... Especially, it seems like the conversion from PDF to PNG is affected for some unknown reason. An example: These look quite the same IMHO. |
I cannot run the whole test suite locally in one go as I get a However, I noted this error from the test log:
So it may indeed be related to what was discussed during the dev call: something messes up the ghostscript conversion process that propagates among the tests. |
Those tend to come from binaries compiled with CPU instruction sets that your CPU does not have...and I have mostly seen them with mkl or other "go fast" numpy extensionss.... |
1c7cd9f
to
4b2dc96
Compare
I'd be happy to finish it. Just that I do not really know what remains to be done and/or what causes the weird inconsistent test images. But I'll try to rebase it and see what the current status is and if anything has changed. |
Co-authored-by: Antony Lee <[email protected]>
4b2dc96
to
b218519
Compare
b218519
to
6b8c2fd
Compare
Co-authored-by: Antony Lee [email protected]
PR Summary
Closes #15491
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).