Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST: Increase fp tolerance on more tests for new NumPy #24266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 25, 2022

PR Summary

This is similar to #22132 in that NumPy has added more code paths that now take advantage of AVX512 optimizations and causes slight variations in results.

Fixes #24060

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

This is similar to matplotlib#22132 in that NumPy has added more code paths that
now take advantage of AVX512 optimizations and causes slight variations
in results.

Fixes matplotlib#24060
@QuLogic QuLogic added this to the v3.6.2 milestone Oct 25, 2022
@QuLogic
Copy link
Member Author

QuLogic commented Oct 25, 2022

This build with nightly wheel installed numpy-1.24.0.dev0+973.g7776bc616 and is passing with this commit.

@QuLogic QuLogic marked this pull request as ready for review October 25, 2022 03:27
@jklymak jklymak merged commit f69a7de into matplotlib:main Oct 25, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 25, 2022
@QuLogic QuLogic deleted the np123 branch October 25, 2022 19:08
QuLogic added a commit that referenced this pull request Oct 25, 2022
…266-on-v3.6.x

Backport PR #24266 on branch v3.6.x (TST: Increase fp tolerance on more tests for new NumPy)
@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TST] Upcoming dependency test failures
3 participants