Rework style sheet reference example to cycle props #24299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
approved these changes
Oct 29, 2022
Sure, let me just squash the commits and update the PR description and checklist. |
There is a different number of circles in the last figure of each style, when cycling is disabled. This causes mismatch between docstring and actual output. Use inifinite props cycler.
703e3ae to
9b4b0b1
Compare
tacaswell
reviewed
Nov 23, 2022
| @@ -63,7 +63,8 @@ def plot_colored_circles(ax, prng, nb_samples=15): | |||
| the color cycle, because different styles may have different numbers | |||
| of colors. | |||
| """ | |||
| for sty_dict, j in zip(plt.rcParams['axes.prop_cycle'], range(nb_samples)): | |||
There was a problem hiding this comment.
I think we need to remove the comment above now?
There was a problem hiding this comment.
actually, on further reading I think the comment above is now more correct (with the range(nb_samples) always being exhausted now rather than sometimes cutting short based on the number of colors.
jklymak
approved these changes
Nov 24, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 29, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 29, 2022
ksunden
added a commit
that referenced
this pull request
Nov 29, 2022
…299-on-v3.6.x Backport PR #24299 on branch v3.6.x (Rework style sheet reference example to cycle props)
ksunden
added a commit
that referenced
this pull request
Nov 29, 2022
…299-on-v3.6.2-doc Backport PR #24299 on branch v3.6.2-doc (Rework style sheet reference example to cycle props)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
There is different number of circles in the last figure of each style, when cycling is disabled.
This causes mismatch between docstring and the actual output.
This tries to support the problem reported in #24022.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst