Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Fix syntax of suggestion #24363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022
Merged

DOC: Fix syntax of suggestion #24363

merged 1 commit into from
Nov 4, 2022

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Nov 4, 2022

PR Summary

PR Checklist

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

I blindly copy-pasted the suggested code and got:

SyntaxError: positional argument follows keyword argument

I changed it to use positional-only, but I could change them all to be kwargs instead if you want.

@tacaswell tacaswell added this to the v3.6.3 milestone Nov 4, 2022
@tacaswell tacaswell modified the milestones: v3.6.3, v3.6-doc Nov 4, 2022
@tacaswell tacaswell merged commit edaaa3a into matplotlib:main Nov 4, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 4, 2022
@tacaswell
Copy link
Member

@meeseeksdev backport to v3.6.2-doc

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 4, 2022

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@tacaswell tacaswell modified the milestones: v3.6-doc, v3.6.3 Nov 4, 2022
timhoffm added a commit that referenced this pull request Nov 4, 2022
…363-on-v3.6.x

Backport PR #24363 on branch v3.6.x (DOC: Fix syntax of suggestion)
@QuLogic
Copy link
Member

QuLogic commented Nov 4, 2022

meeseeksdev backport to v3.6.2-doc

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 4, 2022
@QuLogic QuLogic modified the milestones: v3.6.3, v3.6-doc Nov 4, 2022
timhoffm added a commit that referenced this pull request Nov 4, 2022
…363-on-v3.6.2-doc

Backport PR #24363 on branch v3.6.2-doc (DOC: Fix syntax of suggestion)
@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants