DOC: Cleanup spines usage in examples #24378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hide spines using `set_visible(False)` instead of `set_color('none')`
- remove `ax.xaxis.set_ticks_position('bottom')` and
`ax.yaxis.set_ticks_position('left')`, because these are already the
defaults
- use multi-assignment (`spines[['left', 'bottom']].set_*`) when
possible
- Remove "Custom spine bounds" example. This is already included in the
"Spines" example
tacaswell
approved these changes
Nov 6, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 6, 2022
|
@timhoffm did you mean v3.6.3 instead of v3.6-doc? |
oscargus
added a commit
that referenced
this pull request
Nov 6, 2022
…378-on-v3.6.x Backport PR #24378 on branch v3.6.x (DOC: Cleanup spines usage in examples)
I'm confused. This milestoned v3.6.3 as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_visible(False)instead ofset_color('none')ax.xaxis.set_ticks_position('bottom')andax.yaxis.set_ticks_position('left'), because these are already the defaultsspines[['left', 'bottom']].set_*) when possible