Shorten and explain more calculations in axes_divider. #24461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
approved these changes
Nov 15, 2022
timhoffm
approved these changes
Nov 15, 2022
Comment on lines
156
to
157
| rs_sum, as_sum = sizes.sum(0) | ||
| return (total - as_sum) / rs_sum if rs_sum else 0 |
There was a problem hiding this comment.
While at it, let's use better names
Suggested change
| rs_sum, as_sum = sizes.sum(0) | |
| return (total - as_sum) / rs_sum if rs_sum else 0 | |
| rel_sum, abs_sum = sizes.sum(0) | |
| return (total - abs_sum) / rel_sum if rel_sum else 0 |
There was a problem hiding this comment.
sure, done throughout.
Make get_horizontal_sizes, get_vertical_sizes return arrays (which make subsequent computations easier). Move Divider._calc_k, Divider._calc_offsets closer to their use site (i.e. Divider._locate). Inline and shorten offsetbox._determine_karray, offsetbox._calc_offsets into offsetbox._locate which should make the logic easier to follow.
|
does the code coverage warning need to be resolved? |
|
I would argue it should be, unless we don't care if axes_divider breaks (in which case, why are we optimizing it?) |
|
I don't know that this is a true coverage drop; apparently all the GitHub Actions workflows did not upload anything. |
|
And it's all fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
get_horizontal_sizes,get_vertical_sizesreturn arrays (which make subsequent computations easier). MoveDivider._calc_k,Divider._calc_offsetscloser to their use site (i.e.Divider._locate). Inline and shortenoffsetbox._determine_karray,offsetbox._calc_offsetsintooffsetbox._locatewhich should make the logic easier to follow.PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst