-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fixed issues with errorbar limits #2452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b76263c
Fixed issues with errorbar limits
larrybradley 2be7e7f
Condensed setting values in lines_kw and plot_kw in the errorbar func…
larrybradley f5c787f
added errorbar limit test
larrybradley 8039d12
added comments; fixed typo
larrybradley 263b070
removed extra space; pep8
larrybradley 1b06302
fixes direction of arrowhead plot symbol for inverted x or y axes
larrybradley af6a89b
updated api_changes and whats_new
larrybradley 7cc983d
removed rebase marker in test_axes
larrybradley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added comments; fixed typo
- Loading branch information
commit 8039d12a631c5fb7499d47d1044f87c45c754550
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2754,6 +2754,8 @@ def xywhere(xs, ys, mask): | |
right = [thisx + thiserr for (thisx, thiserr) | ||
in cbook.safezip(x, xerr)] | ||
|
||
# select points without upper/lower limits in x | ||
# draw normal errorbars for these points | ||
noxlims = ~(xlolims | xuplims) | ||
if noxlims.any(): | ||
yo, _ = xywhere(y, right, noxlims & everymask) | ||
|
@@ -2802,6 +2804,8 @@ def xywhere(xs, ys, mask): | |
upper = [thisy + thiserr for (thisy, thiserr) | ||
in cbook.safezip(y, yerr)] | ||
|
||
# select points without upper/lower limits in y | ||
# draw normal errorbars for these points | ||
noylims = ~(lolims | uplims) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for consistency, this line should also get a similar comment |
||
if noylims.any(): | ||
xo, _ = xywhere(x, lower, noylims & everymask) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line deserves a comment