-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: add note about enabling c++11 support for old gcc #24540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the "lazy" option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tacaswell, I tried
export CXXFLAGS=-std=c++11
before the install, but got the same error. Am I misunderstanding how to set this?
It seems like one have to set You will get a warning though for some of the compile steps:
|
Thanks @oscargus
worked for me too. I'm on RHEL7 (apparently next year we get RHEL9...) |
A small follow-up on this. Although it compiles and looks like it installs correctly there is also another message of interest:
and running mpl leads to
Do you get similar behavior @rcomer or does it work for you? (This is for gcc 4.8.5, but I also have 7.3.1 and there it builds without problem, so back to a working version now...) |
@tacaswell I see this is 2 commits. Should I squash-merge or just commit both or something else? |
Closes matplotlib#24530 This will produce warnings, but will compile.
I'll squash this to one (probably should have done that initially). We tend to reserve squash-merging for PRs with many commits and a contributor who does not feel comfortable squashing them selves. |
bb627b9
to
0fd81de
Compare
Cycling CI because it looked like a few checks had network errors that were likely temporary |
You can do that directly in Circle; no need to modify the PR. |
…ort for old gcc
…ort for old gcc
…540-on-v3.6.x Backport PR #24540 on branch v3.6.x (DOC: add note about enabling c++11 support for old gcc)
…540-on-v3.6.2-doc Backport PR #24540 on branch v3.6.2-doc (DOC: add note about enabling c++11 support for old gcc)
Closes #24530
@rcomer Can you confirm if this works for you?