Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Clarify supported animation formats in animation tutorial #24542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2022
Merged

DOC: Clarify supported animation formats in animation tutorial #24542

merged 1 commit into from
Nov 25, 2022

Conversation

StefRe
Copy link
Contributor

@StefRe StefRe commented Nov 24, 2022

PR Summary

  • fix table to state the same as the text (ImageMagickWriter supports all formats supported by imagemagick) and add some examples (the extra args for apng are needed to reduce filesize by ~10x)
  • add .webp as supported format to Pillow (since 2018 vers 5.0.0 )
  • fix table formatting

OLD
grafik

NEW
grafik

PR Checklist

Documentation and Tests

  • [N/A] Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@story645 story645 added this to the v3.7.0 milestone Nov 24, 2022
story645
story645 approved these changes Nov 24, 2022
View reviewed changes
@StefRe
DOC: Clarify supported animation formats in animation tutorial
89cd9e7 
- fix table to state the same as the text (ImageMagickWriter supports
  all formats supported by imagemagick) and add some examples
  (the extra args for apng are needed to reduce filesize by ~10x)
- add .webp as supported format to Pillow (since 2018 vers 5.0.0 )
- fix table formatting
@StefRe StefRe force-pushed the fix/animation_tutorial branch from c5731e7 to 89cd9e7 Compare November 24, 2022 14:48
@StefRe
Copy link
Contributor Author

StefRe commented Nov 24, 2022

not sure what this error means, but it seems to be unrelated to this PR:

Failed to fetch https://packagecloud.io/github/git-lfs/ubuntu/dists/jammy/InRelease 402 Payment Required [IP: 13.56.57.255 443]

@story645
Copy link
Member

Yeah 😶 does this PR build locally for you?

@StefRe
Copy link
Contributor Author

StefRe commented Nov 24, 2022

yes, it now looks like this:

grafik

@story645 story645 merged commit 312fdb7 into matplotlib:main Nov 25, 2022
@story645
Copy link
Member

Thanks for doing this! If you want a follow up, linking to the list of supported file types in ffmpeg and imagemagick would be much appreciated (and also do you prefer asks like that as part of the review or as a follow up? - if you have no time or intrest, is 100% fine)

@StefRe StefRe mentioned this pull request Nov 25, 2022
Merged
1 task
@StefRe
Copy link
Contributor Author

StefRe commented Nov 25, 2022

If you want a follow up, linking to the list of supported file types in ffmpeg and imagemagick would be much appreciated

see #24544

@StefRe StefRe deleted the fix/animation_tutorial branch November 25, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
Documentation topic: animation
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@StefRe @story645