Add explicit permissions to GitHub Actions#24579
Merged
Merged
Conversation
Also update the CircleCI check to the action's latest recommended jobs.
67334d7 to
feec9c5
Compare
Member
Author
|
I threw in a few bugs, and they were correctly reported, so I've removed them now. Not 100% confident on the nightly bits, as the GitHub docs are a bit vague on what the permissions do, but I think they're correct. |
ksunden
approved these changes
Dec 2, 2022
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Dec 2, 2022
Merge pull request matplotlib#24579 from QuLogic/action-permissions Add explicit permissions to GitHub Actions (cherry picked from commit 24f9128)
QuLogic
added a commit
that referenced
this pull request
Dec 3, 2022
…-v3.6.x Backport PR #24579: Add explicit permissions to GitHub Actions
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
While everything we do is basically public, there's no reason to give the tokens on these jobs full permissions. (Note, once a single item is added, all other permissions are disabled.)
Also update the CircleCI check to the action's latest recommended jobs.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst