Simplify implementation of _is_sorted. #24581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need a separate specialization for ints (we can rely on the compiler to inline isnan as always false), and having a separate loop to find the first non-nan value isn't necessary either.
One change in behavior this causes (in this private function) is that a fully nan input is considered as being sorted, but this is consistent with empty inputs being considered sorted too, and also OK with the actual use of the function (determine whether to go through a fast path in drawing lines -- fully nan lines are not drawn anyways).
followup to #24575, which I unfortunately have to slightly revert (going back to
x != x
) due to the lack ofisnan(IntegralValue)
on MSVC (https://stackoverflow.com/questions/61646166/how-to-resolve-fpclassify-ambiguous-call-to-overloaded-function), even though cppreference declares that it should exist (https://en.cppreference.com/w/cpp/numeric/math/isnan)...PR Summary
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst