Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: tweak wording on Figure.show warning #24607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

tacaswell
Copy link
Member

PR Summary

closes #22169

PR Checklist

Documentation and Tests

  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@tacaswell tacaswell added this to the v3.6.3 milestone Dec 3, 2022
@tacaswell tacaswell requested a review from timhoffm December 3, 2022 22:15
Comment on lines 2620 to 2621
Some, but not all, GUI toolkits will register an input hook on
import. See :ref:`cp_integration` for more details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, but I find these changes much more confusing than the original. What is an "input hook"? What is a "GUI toolkit", and why do they register an "input hook"? Where do they register it? and what does "on import" mean? On import of what?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there is a typo in the previous paragraph "an GUI even loop"...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does include a link to the (much) longer explanation.

#22169 noted that they found a case where it did work. The goal was to add a few more details about when you should expect this to work or not.


If you're in a shell without input hook integration or executing a
python script, you should use `matplotlib.pyplot.show` with
``block=True`` instead, which takes care of starting and running
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block=True is the default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default depends on if we are in "interactive mode" or not.

Co-authored-by: Oscar Gustafsson <[email protected]>
Co-authored-by: Jody Klymak <[email protected]>
@timhoffm timhoffm merged commit 666c7e3 into matplotlib:main Dec 13, 2022
@QuLogic
Copy link
Member

QuLogic commented Dec 13, 2022

meeseeksdev backport to v3.6.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 13, 2022
QuLogic added a commit that referenced this pull request Dec 14, 2022
…607-on-v3.6.x

Backport PR #24607 on branch v3.6.x (DOC: tweak wording on Figure.show warning)
@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: figure.show works beyond what is documented
6 participants