Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed issue #23171 where axes vlines() / hlines() doesn't autoscale correctly with blended transform. #24695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed issue #23171 where axes vlines() / hlines() doesn't autoscale correctly with blended transform. #24695

wants to merge 1 commit into from

Conversation

aalmasmari
Copy link
Contributor

@aalmasmari aalmasmari commented Dec 11, 2022 •
edited
Loading

PR Summary

Changed vlines() and hlines() of axes to not autoscale on the horizontal/vertical axis given a transform argument. This is so that it doesn't autoscale incorrectly, treating the minimum argument as a data coordinate, as mentioned in issue #23171

PR Checklist

Documentation and Tests

  • [ Yes] Has pytest style unit tests (and pytest passes)
  • [ N/A ] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [ N/A ] New plotting related features are documented with examples.

Release Notes

  • [N/A ] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [ N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [N/A ] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@aalmasmari aalmasmari changed the title Fixed issue where axes vlines() / hlines() doesn't autoscale correctly with blended transform. Fixed issue #23171 where axes vlines() / hlines() doesn't autoscale correctly with blended transform. Dec 12, 2022
@aalmasmari aalmasmari marked this pull request as ready for review December 12, 2022 01:38
@jklymak
Copy link
Member

jklymak commented Jan 22, 2023

@aalmasmari Sorry for the poor response on this. It would be helpful if you included the before and after behaviour change this introduces, and/or added tests to tests/test_axes.py near the other test_hline tests. Otherwise, you are asking us to do a lot of detective work to figure out what this fixes and why the fix is correct. Thanks!

@jklymak
Copy link
Member

jklymak commented Jan 30, 2023

Moving to draft pending response! Thanks!

@jklymak jklymak marked this pull request as draft January 30, 2023 23:30
QuLogic
QuLogic reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct fix, as the wrong values are already added to the data limits. If another thing is plotted afterwards that requests an autoscale of the skipped direction, then the problem will still occur.

@melissawm
Copy link
Member

Hi folks - do we have a way forward here?

@QuLogic
Copy link
Member

QuLogic commented Apr 4, 2023

I think the correct fix is moving forward in #25324.

@melissawm
Copy link
Member

Ok. So does this mean this one should be closed, or is there anything we can do here?

@QuLogic
Copy link
Member

QuLogic commented Apr 19, 2023

Yes, now that I've merged #25324, I think we can close this one.

@QuLogic QuLogic closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

Assignees
No one assigned
Labels
status: needs tests
Projects
First Time Contributors
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aalmasmari @jklymak @melissawm @QuLogic