MNT: Simplify code related to masked arrays #24758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Simplified a bit of code related to masked arrays.
basic_units
: already converted to non-masked a few lines upticker
: may just as well use the MaskedConstant class (clearer, only a single check)MaskedArray
is a subclass ofnparray
(Was about to change many
isinstance(.., MaskedArray)
tois_masked
, but the time foris_masked
is much higher compared toisinstance()
, so while it probably will be beneficial in the few cases where aMaskedArray
object does not have any masked content, this seems a bit too exotic. One may consider the opposite though, replaceis_masked
withisinstance
.)PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst