Don't set the never-used Line2D._contains in set_picker. #24761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _contains attribute is never accessed anywhere in the library (since the removal of get/set_contains). Note that this patch intentionally doesn't try to disentangle the much more complex interplay between set_picker and set_pickradius...
rcomer
approved these changes
Dec 18, 2022
timhoffm
approved these changes
Dec 18, 2022
Marvvxi
pushed a commit
to Marvvxi/matplotlib
that referenced
this pull request
Dec 20, 2022
…24761) The _contains attribute is never accessed anywhere in the library (since the removal of get/set_contains). Note that this patch intentionally doesn't try to disentangle the much more complex interplay between set_picker and set_pickradius...
raphaelquast
pushed a commit
to raphaelquast/matplotlib
that referenced
this pull request
Mar 16, 2023
…24761) The _contains attribute is never accessed anywhere in the library (since the removal of get/set_contains). Note that this patch intentionally doesn't try to disentangle the much more complex interplay between set_picker and set_pickradius...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _contains attribute is never accessed anywhere in the library (since the removal of get/set_contains). Note that this patch intentionally doesn't try to disentangle the much more complex interplay between set_picker and set_pickradius (#19039)...
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst