Fix/zorder rasterization #24768
Merged
Fix/zorder rasterization #24768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an artist was rasterized both by setting state on the artist and be being below the z-order threshold than we would try to stop rasterization one too many times. This constructions lets us re-use the `allow_rasterization` logic. closes matplotlib#24235
QuLogic
reviewed
Dec 20, 2022
Co-authored-by: Elliott Sales de Andrade <[email protected]>
QuLogic
approved these changes
Dec 21, 2022
QuLogic
reviewed
Dec 21, 2022
Co-authored-by: Elliott Sales de Andrade <[email protected]>
ksunden
approved these changes
Dec 21, 2022
|
Anyone can merge upon test completion |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #24235
This is a bug fix, but I think it is too big to backport and we broke this a while ago so this is not an urgent regression.
PR Checklist
Documentation and Tests
pytestpasses)