Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Better default bool contour levels. #24870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

Better default bool contour levels. #24870

merged 1 commit into from
Jan 4, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 2, 2023

PR Summary

Closes #24321: for bool inputs, contour now defaults to levels=[.5] and contourf to levels=[0, .5, 1].

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

oscargus
oscargus reviewed Jan 3, 2023
View reviewed changes
@anntzer anntzer force-pushed the autoboolcontourlevels branch from c56e0c2 to c1a9443 Compare January 3, 2023 10:24
@ksunden ksunden added this to the v3.7.0 milestone Jan 3, 2023
timhoffm
timhoffm reviewed Jan 3, 2023
View reviewed changes
@anntzer anntzer force-pushed the autoboolcontourlevels branch from c1a9443 to 8fa71f9 Compare January 4, 2023 09:37
@dstansby
Copy link
Member

dstansby commented Jan 4, 2023

Anyone feel free to merge if/when CI passes

@ksunden ksunden merged commit 2392093 into matplotlib:main Jan 4, 2023
@anntzer anntzer deleted the autoboolcontourlevels branch January 4, 2023 15:44
@ksunden ksunden mentioned this pull request Jan 27, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm left review comments

@oscargus oscargus oscargus left review comments

@rcomer rcomer rcomer left review comments

@ksunden ksunden ksunden approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: contour
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

[ENH]: Auto-detect bool arrays passed to contour()?
6 participants
@anntzer @dstansby @ksunden @timhoffm @oscargus @rcomer