Document "." as a filled marker.#24879
Merged
ksunden merged 1 commit intomatplotlib:mainfrom Jan 4, 2023
Merged
Conversation
story645
reviewed
Jan 3, 2023
|
|
||
| for j, marker in enumerate(mlines.Line2D.filled_markers): | ||
| for j, marker in enumerate([ | ||
| m for m in mlines.Line2D.filled_markers if m != "."]): |
Member
There was a problem hiding this comment.
why not update the reference image to include '.'?
Contributor
Author
There was a problem hiding this comment.
It's not really worth regen'ing the image.
Member
There was a problem hiding this comment.
Please make this clear in a comment so that one can easily understand why it's there and remove the exclusion if the image is regenerated for some other reason.
Btw that test image changes are expensive is a nuisance. Maybe we can move that topic via paid/contract work?
Contributor
Author
There was a problem hiding this comment.
Commented.
The baseline image has already been discussed at length elsewhere, let's not derail this PR with it.
oscargus
reviewed
Jan 4, 2023
... which it really is. Also remove a bunch of unnecessary plt.show() from the marker reference example, to make it more convenient to run from the command line.
oscargus
approved these changes
Jan 4, 2023
ksunden
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... which it really is. Closes #23849.
Also remove a bunch of unnecessary plt.show() from the marker reference example, to make it more convenient to run from the command line.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst