Let quiver retrieve X, Y from base PolyCollection.get_offsets(). #24952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of additionally storing copies locally in `self.X, self.Y, self.XY` (for quiver), `self.x, self.y` (for barbs). Then there's no reason not to also suggest set_offsets in quiver(), like it's already done in barbs().
ianhi
reviewed
Jan 12, 2023
Comment on lines
+451
to
+453
| orientation, and color of the arrows. Locations are changed using the | ||
| (inherited) `.PolyCollection.set_offsets` method. This method may be | ||
| useful in animations. |
There was a problem hiding this comment.
Unfortunately I think the behavior is a little bit more complicated than than just using set_offsets due to the interactions of UVC and XY which may be difficult for users to discover. See #22407
|
Ah, sorry I missed your PR. Let's put this on hold first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of additionally storing copies locally in
self.X, self.Y, self.XY(for quiver),self.x, self.y(for barbs).Then there's no reason not to also suggest set_offsets in quiver(), like it's already done in barbs().
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst