Rewrite bullseye example to use bar() instead of pcolormesh(). #24967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason then to keep this as a standalone and not merge w/ https://matplotlib.org/devdocs/gallery/pie_and_polar_charts/nested_pie.html ? Or at least then link to this example from that one as an advanced example? |
|
Whether or not this is a good change depends on the goal of the example? If it's just to create a bullseye plot then the change seems fine. If it's to show off the flexibility of pcolormesh, then maybe both methods are worth showing? |
It is much simpler to take advantage of bar()'s support for polar plots. Also improve z-ordering of various elements so that edges don't get overdrawn (or clipped).
|
I would say this is a quite bad usage of pcolormesh: it needs to create the segments one at a time and even then needs to manually generate interpolated theta values to get the right shapes. |
jklymak
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is much simpler to take advantage of bar()'s support for polar plots. Also improve z-ordering of various elements so that edges don't get overdrawn (or clipped).
before
after
Note the subtle difference in the bold edges in the last plot.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst