Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve 3D quiver test #24995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Improve 3D quiver test #24995

merged 2 commits into from
Jan 20, 2023

Conversation

dstansby
Copy link
Member

PR Summary

The previous test images had arrows so small they were hard to make out. The new test image has arrows that can be seen, and also merges the three different pivot values into one test image, reducing the number of test images by two.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus
Copy link
Member

oscargus commented Jan 15, 2023

Sorry, I updated my comment. I didn't notice that you used mpl3d_image_comparison which sets it to 'default' which is the same as 'mpl20' (but not the default value for image_comparison...).

@QuLogic QuLogic merged commit 761414e into matplotlib:main Jan 20, 2023
@QuLogic QuLogic added this to the v3.8.0 milestone Jan 20, 2023
@dstansby dstansby deleted the 3dquiver-test branch January 20, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants