Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: Re-add the login shell to nightlies jobs #25046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2023
Merged

ci: Re-add the login shell to nightlies jobs #25046

merged 1 commit into from
Jan 21, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 21, 2023

PR Summary

This is needed because of the way the micromamba provisioning works, or else anything installed in the mamba environment is not found.

I also added a comment explaining it so that it won't be accidentally removed in the future (or will if that requirement is dropped.)

Now that I know you can trigger workflow_dispatch runs from any branch, I checked this before opening this PR: https://github.com/matplotlib/matplotlib/actions/runs/3972489758

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

This is needed because of the way the micromamba provisioning works, or
else anything installed in the mamba environment is not found.
@QuLogic QuLogic added this to the v3.8.0 milestone Jan 21, 2023
@oscargus oscargus merged commit 8ed4c02 into main Jan 21, 2023
@oscargus oscargus deleted the fix-nightlies branch January 21, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants