Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support both Bbox and list for bbox to table/Table #25052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2023
Merged

Support both Bbox and list for bbox to table/Table #25052

merged 1 commit into from
Feb 9, 2023

Conversation

oscargus
Copy link
Member

PR Summary

Closes #25048

The documentation stated that a Bbox should be passed, but in reality one should pass (x, y, width, height). Now, both formats can be passed.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus oscargus marked this pull request as ready for review January 21, 2023 16:17
rcomer
rcomer reviewed Jan 22, 2023
View reviewed changes
@jklymak
Copy link
Member

jklymak commented Feb 8, 2023

I'll move to draft, but feel free to move back...

@jklymak jklymak marked this pull request as draft February 8, 2023 15:05
@oscargus oscargus marked this pull request as ready for review February 9, 2023 18:17
@rcomer rcomer added the PR: bugfix Pull requests that fix identified bugs label Feb 9, 2023
@rcomer rcomer added this to the v3.7.1 milestone Feb 9, 2023
@rcomer rcomer merged commit 75e2d22 into matplotlib:main Feb 9, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 9, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 9, 2023
@rcomer @meeseeksmachine
Backport PR matplotlib#25052: Support both Bbox and list for bbox to …
3670d41 
…table/Table
@ksunden ksunden modified the milestones: v3.7.1, v3.7.0 Feb 9, 2023
dstansby added a commit that referenced this pull request Feb 9, 2023
@dstansby
Merge pull request #25182 from meeseeksmachine/auto-backport-of-pr-25…
006d2f5 
…052-on-v3.7.x

Backport PR #25052 on branch v3.7.x (Support both Bbox and list for bbox to table/Table)
@oscargus oscargus deleted the tablebbox branch February 9, 2023 21:13
@ksunden ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@rcomer rcomer rcomer approved these changes

Assignees
No one assigned
Labels
PR: bugfix Pull requests that fix identified bugs topic: table
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

[Doc]: matplotlib.axes.Axes.table bbox parameter
4 participants
@oscargus @jklymak @rcomer @ksunden