Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add new SI prefixes to ticker #25087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

MichaDit
Copy link
Contributor

PR Summary

Add the new SI prefixes to ticker (-30, -27, 27, 30) according to BIPM The International System of Units
9th edition (2019) - see Table 7. SI prefixes

If there is Documentation or Release Note needed for this, let me know.

PR Checklist

Documentation and Tests

  • [N/A] Has pytest style unit tests (and pytest passes)
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@MichaDit MichaDit force-pushed the feat/add-new-si-prefixes branch from e57e280 to 859d726 Compare January 25, 2023 23:32
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@WeatherGod WeatherGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs a what's-new etc.

@MichaDit MichaDit force-pushed the feat/add-new-si-prefixes branch from 859d726 to ca807d1 Compare January 26, 2023 00:07
@MichaDit MichaDit force-pushed the feat/add-new-si-prefixes branch from ca807d1 to 107fa52 Compare January 26, 2023 00:10
@tacaswell tacaswell added this to the v3.8.0 milestone Jan 26, 2023
@ksunden
Copy link
Member

ksunden commented Jan 26, 2023

Pretty sure the Circle test failures are unrelated (looked like a few of the intersphinx lookups failed), rerunning to be sure

@ksunden ksunden merged commit d731d48 into matplotlib:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

6 participants