Reset _transformSet in Artist.remove#25205
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
I am more in favor of preventing re-adding artists (see #24626) because I suspect that this is one of a bunch of connections that are not being properly cleaned up. |
|
I am guessing from @tacaswell's comment that tests are not all that is needed here, but may be a good starting point. @komoto48g if you need help with adding the tests, let us know. Here are the Matplotlib testing guidelines: https://matplotlib.org/devdocs/devel/testing.html |
PR Summary
This PR fixes #25168
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst