Add mpl_round_to_int #25207
Merged
Add mpl_round_to_int #25207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Feb 13, 2023
jklymak
reviewed
Feb 13, 2023
| inline double mpl_round(double v) | ||
| { | ||
| return (double)(int)(v + ((v >= 0.0) ? 0.5 : -0.5)); | ||
| return (double)mpl_round_to_int(v); |
There was a problem hiding this comment.
Is there a reason mpl_round doesn't work here? Does mpl_round handle 0.5 differently?
There was a problem hiding this comment.
mpl_round does (double)(int)... while mpl_round_to_int does (int).... So I thought that inlining it will avoid code duplication. It should be identical.
jklymak
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Most uses of
mpl_roundis casting back toint, so better keep the result asint. It may be possible that the compiler realizes that(int)(double)(int)should be simplified to(int)though...PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst