Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove a redundant comma in AsinhScale #25232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

YDX-2147483647
Copy link
Contributor

PR Summary

This PR doesn't directly solve any real-world problems, but will make life easier in the future.

if self._base > 1:
    axis.set_major_formatter(LogFormatterSciNotation(self._base))
else:
    axis.set_major_formatter('{x:.3g}'),
                                       👆

The comma doesn't have any effect, but triggers a lint warning: Expression value is unused. (a, means the tuple (a,))

Additional information: This line was introduced in 65eff09.

⚠️ I'm not sure whether this kind of PR is welcomed. If not so, sorry for taking up time.

PR Checklist

Documentation and Tests

  • [N/A] Has pytest style unit tests (and pytest passes)
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

The comma doesn't have any effect, but triggers a lint warning: Expression value is unused.

(`a,` means the tuple `(a,)`)
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our linter doesn't care about this, but agreed it is unnecessary..

@jklymak
Copy link
Member

jklymak commented Feb 16, 2023

This is so trivial, I'll merge w/ one review...

@jklymak jklymak merged commit 22d036e into matplotlib:main Feb 16, 2023
@jklymak jklymak added this to the v3.8.0 milestone Feb 16, 2023
@YDX-2147483647 YDX-2147483647 deleted the patch-1 branch February 16, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants