Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix unmatched offsetText label color #25287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Conversation

devRD
Copy link
Contributor

@devRD devRD commented Feb 22, 2023

PR Summary

Fixes #25165
Updates the offset text color according to the tick attribute "labelcolor" or "color"

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@devRD devRD marked this pull request as ready for review February 23, 2023 12:50
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the new tests be checking offsetText?

@QuLogic QuLogic merged commit 631d1ab into matplotlib:main Mar 1, 2023
@QuLogic QuLogic added this to the v3.8.0 milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: offsetText is colored based on tick.color instead of tick.labelcolor
3 participants