Cleanup gradient_bar example. #25302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
approved these changes
Feb 23, 2023
- Don't list `extent` explicitly in the signature, but let it be passed as kwargs. (It's not more, or less, special than `transform`.) - Use the shorter `clim` instead of `vmin, vmax`. - Pass aspect="auto" within gradient_image (the caller shouldn't have to do that).
|
Indeed, fixed. |
|
The pipeline is finished; I don't know why it's not reporting to GitHub. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 23, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 23, 2023
QuLogic
added a commit
that referenced
this pull request
Feb 23, 2023
…302-on-v3.7.0-doc Backport PR #25302 on branch v3.7.0-doc (Cleanup gradient_bar example.)
oscargus
added a commit
that referenced
this pull request
Feb 23, 2023
…302-on-v3.7.x Backport PR #25302 on branch v3.7.x (Cleanup gradient_bar example.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extentexplicitly in the signature, but let it be passed as kwargs. (It's not more, or less, special thantransform.)climinstead ofvmin, vmax.PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst