FIX: use wrapped text in Text._get_layout #25346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Feb 28, 2023
| @@ -367,7 +367,7 @@ def _get_layout(self, renderer): | |||
| of a rotated text when necessary. | |||
| """ | |||
| thisx, thisy = 0.0, 0.0 | |||
| lines = self.get_text().split("\n") # Ensures lines is not empty. | |||
| lines = self._get_wrapped_text().split("\n") # Ensures lines is not empty. | |||
There was a problem hiding this comment.
Do you understand what the comment is about?
There was a problem hiding this comment.
Not completely, though I can see that there are a bunch of necessary variables defined in the loop at lines 383-414, which would not exist if lines was empty. So maybe this is just providing reassurance for that?
timhoffm
approved these changes
Feb 28, 2023
jklymak
approved these changes
Feb 28, 2023
|
@meeseeksdev backport to v3.7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 28, 2023
oscargus
added a commit
that referenced
this pull request
Feb 28, 2023
…346-on-v3.7.x Backport PR #25346 on branch v3.7.x (FIX: use wrapped text in Text._get_layout)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #25336.
Constrained layout here relies on
Text.get_tightbbox, which callsText.get_window_extent, which callsText._get_layout. The example code in the issue now produces:PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst