Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Better axis labels for examples #25388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Better axis labels for examples #25388

merged 1 commit into from
Mar 5, 2023

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Mar 5, 2023

PR Summary

Not so clear which label is which if the same label text is used.

Also, changed the casing of the example name. 1 and 3 are not ideal, but not really sure what a better name should be.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus oscargus added this to the v3.7-doc milestone Mar 5, 2023
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 and 3 are not ideal, but not really sure what a better name should be.

3 does not seem to modify the axis direction (unless I'm missing something - I'm new to the axisartist module). So maybe "Simple axis direction" and "Simple ticklabel direction"?

@oscargus
Copy link
Member Author

oscargus commented Mar 5, 2023

Thanks for the suggestion! I applied it with a slight modification and also with a bit of text about the second example.

(I changed to move the ticks to the inside as I think that the default has changed from inside to outside, so no need to move to the outside.)

rcomer added a commit that referenced this pull request Mar 5, 2023
…388-on-v3.7.1-doc

Backport PR #25388 on branch v3.7.1-doc (Better axis labels for examples)
rcomer added a commit that referenced this pull request Mar 5, 2023
…388-on-v3.7.x

Backport PR #25388 on branch v3.7.x (Better axis labels for examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants