Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DOC] Clarify how to change side of the TickedStroke ticks #25394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Mar 5, 2023

PR Summary

Took me a while and a bit of trial and error to figure it out.

The ant example in the doc-string is not that good since for plot, it seems like to points are reordered, so plot([0, 1], [0, 1]) and plot([1, 0], [1, 0]) actually gives the same tick direction. I guess it is correct though, and that plot swaps when creating the line.

One may argue if changing sign or adding/subtracting 180 is the "correct way", but I think that once one realize that it is the angle that one should modify, one can figure out the rest. (Changing sign of the length is also an option, but more limited and I do not think that has any actual advantage...)

Must of course not go into 3.7.2, but if it was only the example, it would probably go into 3.7-doc and so on.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus oscargus marked this pull request as ready for review March 5, 2023 18:02
@oscargus oscargus added this to the v3.7.2 milestone Mar 5, 2023
@oscargus oscargus force-pushed the patheffectsdocs2 branch 2 times, most recently from 96ac3ef to 9a2175d Compare March 5, 2023 18:23
@oscargus oscargus force-pushed the patheffectsdocs2 branch 2 times, most recently from fe3f819 to 3f2e21b Compare March 12, 2023 16:42
@QuLogic QuLogic merged commit a812352 into matplotlib:main Mar 13, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 13, 2023
@oscargus oscargus deleted the patheffectsdocs2 branch March 13, 2023 22:02
QuLogic added a commit that referenced this pull request Mar 14, 2023
…394-on-v3.7.x

Backport PR #25394 on branch v3.7.x ([DOC] Clarify how to change side of the TickedStroke ticks)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants