DOC: add a note about linewidth to scatter docs #25414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is fine, but |
QuLogic
reviewed
Mar 11, 2023
closes matplotlib#25410 Co-authored-by: Elliott Sales de Andrade <[email protected]>
124435f to
6064a2e
Compare
|
I added a note about edgecolor, but I think setting the color to none and the linewidth to 0 are equally idiomatic. |
jklymak
approved these changes
Mar 31, 2023
Co-authored-by: Jody Klymak <[email protected]>
c4304b3 to
732ec3a
Compare
ksunden
reviewed
Mar 31, 2023
Co-authored-by: Kyle Sunden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #25410
I do not think the long analysis in the comments of #25410 has a good home in the docs, but hopefully this is enough to point people in the right direction if things look funny.
There was another issue (that I can not find again) that reported the area of markers was too big (but they might have been using
Circle) so also added a note about that while I was touching this docstring.PR Checklist
Documentation and Tests
pytestpasses)