Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add references to backend_{gtk3,gtk4,wx} in docs. #25457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 14, 2023

These modules are not actual backends but rather serve as bases for the corresponding agg/cairo backends, but adding them to the docs allows referring to them from elsewhere.

Note that backend_qt is already listed; _backend_tk is currently private but we could consider making it (or a subset of it) public like the others (I already rely on it in mplcairo, for example).

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

These modules are not actual backends but rather serve as bases for the
corresponding agg/cairo backends, but adding them to the docs allows
referring to them from elsewhere.

Note that backend_qt is already listed; _backend_tk is currently private
but we could consider making it (or a subset of it) public like the
others (I already rely on it in mplcairo, for example).
@jklymak
Copy link
Member

jklymak commented Mar 14, 2023

Without looking - how well explained are the differences between these and the full backends? These almost should be called something else?

@anntzer
Copy link
Contributor Author

anntzer commented Mar 14, 2023

There's currently really no docs for either the bases or the full backends in the API docs (e.g. https://matplotlib.org/stable/api/backend_gtk4_api.html), so as not to require the GUI toolkits to be present when building the docs. So in general better documentation would be nice, but that'd be a much bigger project than just adding entries like this PR does.

@oscargus oscargus added this to the v3.7-doc milestone Mar 14, 2023
@oscargus oscargus merged commit 556f57a into matplotlib:main Mar 14, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 14, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 14, 2023
@anntzer anntzer deleted the bd branch March 14, 2023 17:06
ksunden added a commit that referenced this pull request Mar 14, 2023
…457-on-v3.7.x

Backport PR #25457 on branch v3.7.x (Add references to backend_{gtk3,gtk4,wx} in docs.)
ksunden added a commit that referenced this pull request Mar 14, 2023
…457-on-v3.7.1-doc

Backport PR #25457 on branch v3.7.1-doc (Add references to backend_{gtk3,gtk4,wx} in docs.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants