-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
ci: Merge sdist and wheel building workflows #25473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So some annoyance here: we still build 32-bit wheels, but NumPy doesn't. When we build ourselves, we ask for This will probably also affect some of the ARM builds? Which will really explode the runtime for this workflow. Maybe we'll have to get by without the test... |
I'm not following how an echo on the test command verifies that it didn't totally fail. Don't you need to To avoid the long stacked wheel builds in a single job, I've switched over to dynamically generating the run matrix on other projects which has worked nicely: pypa/cibuildwheel#1261 Perhaps we should open a separate issue about the 32-bit wheels, but it seems like if Numpy has dropped direct wheel support, we could probably follow suit as well and not bother with the extra maintenance there. |
cibuildwheel creates the test environment and installs the wheel when there's a test command. Setting the environment variable just triggers this behaviour; it doesn't matter that it doesn't do anything. I opened #25475 for dropping 32-bit wheels. We did discuss doing a bit more testing, but that can wait for after the above change. |
That wasn't obvious to me, thanks for clarifying! I did go in and look at the CI log to verify that does work 👍 . Perhaps add a comment above that to indicate as much? |
Looks like there was a temporary disruption in the qhull download |
I've realized that the |
797e2d9
to
5f89ec0
Compare
Sorry, that took a few tries to get working across platforms. Annnd now we know that PyPy wheels don't import on Windows. Can anyone try that out with the release wheels? Or the previous nightly wheels? |
Well, it seems to have magically fixed itself in the meantime. |
This allows verifying that wheels can be installed after building, and that the sdist can be built into a wheel without a second workflow. Also simplify some of the checking scripts.
PR Summary
This allows verifying that wheels can be installed after building, and that the sdist can be built into a wheel without a second workflow.
Also simplify some of the checking scripts.
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst