DOC: remove rcdefaults from barh example #25486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Mar 17, 2023
|
"View the built docs" link seems to be missing here and on other recent PRs too 😕 |
ksunden
approved these changes
Mar 17, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 17, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 17, 2023
ksunden
added a commit
that referenced
this pull request
Mar 17, 2023
…486-on-v3.7.x Backport PR #25486 on branch v3.7.x (DOC: remove rcdefaults from barh example)
ksunden
added a commit
that referenced
this pull request
Mar 17, 2023
…486-on-v3.7.1-doc Backport PR #25486 on branch v3.7.1-doc (DOC: remove rcdefaults from barh example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The call to
rcdefaultsin this example seems superfluous. Because it's there, the example is linked from the API docs for rcdefaults, which gives the user the impression that they may learn more about the function by looking at the example. The other linked example is much more useful for this.PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst