Ignore errors loading artifacts from CircleCI#25494
Merged
ksunden merged 1 commit intomatplotlib:mainfrom Mar 20, 2023
Merged
Conversation
Previously, this seemed to be ignored, and we'd just get a 0-artifact count. But now it seems that requesting artifacts for builds that are incomplete raises a 400 Bad Request. So ignore those errors and return a 0-length artifact, because that is already correctly handled by the next step in the workflow.
oscargus
approved these changes
Mar 20, 2023
ksunden
approved these changes
Mar 20, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 20, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 20, 2023
ksunden
added a commit
that referenced
this pull request
Mar 20, 2023
…494-on-v3.7.1-doc Backport PR #25494 on branch v3.7.1-doc (Ignore errors loading artifacts from CircleCI)
ksunden
added a commit
that referenced
this pull request
Mar 20, 2023
…494-on-v3.7.x Backport PR #25494 on branch v3.7.x (Ignore errors loading artifacts from CircleCI)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously, this seemed to be ignored, and we'd just get a 0-artifact count. But now it seems that requesting artifacts for builds that are incomplete raises a 400 Bad Request.
So ignore those errors and return a 0-length artifact, because that is already correctly handled by the next step in the workflow.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst