Add ipykernel as an explicit doc dependency #25524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously was a transitive dependency from ipywidgets, but that was removed in favor of a lower level comm package created/used by the jupyter ecosystem (including ipykernel). Upon them releasing that change, Circle doc builds began failing as the nbagg/webagg backends require ipykernel and it was not installed. Reference https://github.com/jupyter-widgets/ipywidgets/pull/3533/files#diff-d3df85288b79c378bd5be0ae897814abd0db4f90bed160b7259d805a7e77425e
jklymak
approved these changes
Mar 21, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 21, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 21, 2023
ksunden
added a commit
that referenced
this pull request
Mar 22, 2023
…524-on-v3.7.1-doc Backport PR #25524 on branch v3.7.1-doc (Add ipykernel as an explicit doc dependency)
ksunden
added a commit
that referenced
this pull request
Mar 22, 2023
…524-on-v3.7.x Backport PR #25524 on branch v3.7.x (Add ipykernel as an explicit doc dependency)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously was a transitive dependency from ipywidgets, but that was
removed in favor of a lower level comm package created/used by the
jupyter ecosystem (including ipykernel).
Upon them releasing that change, Circle doc builds began failing as the
nbagg/webagg backends require ipykernel and it was not installed.
Reference https://github.com/jupyter-widgets/ipywidgets/pull/3533/files#diff-d3df85288b79c378bd5be0ae897814abd0db4f90bed160b7259d805a7e77425e
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst