Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove explicit symbol visibility pragmas #25539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2023
Merged

Remove explicit symbol visibility pragmas #25539

merged 1 commit into from
Mar 24, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 23, 2023 •
edited
Loading

PR Summary

Since Python 3.9, the PyMODINIT_FUNC has included explicit default visibility [1], and so works when we set visibility to be hidden globally.

[1] python/cpython@0b60f64

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic QuLogic added the Build label Mar 23, 2023
@QuLogic QuLogic added this to the v3.8.0 milestone Mar 23, 2023
@QuLogic
Remove explicit symbol visibility pragmas
cbae84b 
Since Python 3.9, the `PyMODINIT_FUNC` has included explicit default
visibility [1], and so works when we set visibility to be hidden
globally.

[1] python/cpython@0b60f64
@QuLogic QuLogic force-pushed the no-extra-visibility branch from 334303b to cbae84b Compare March 24, 2023 00:06
@QuLogic
Copy link
Member Author

QuLogic commented Mar 24, 2023

This also fixes several warning C4068: unknown pragma warnings from MSVC when building on Windows.

@ksunden ksunden merged commit 161c96c into matplotlib:main Mar 24, 2023
@QuLogic QuLogic deleted the no-extra-visibility branch March 25, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @tacaswell @ksunden