Fix return type of get_plot_commands #25580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typing PR found that this was returning a generator [1], but this was an error from matplotlib#24000, as 3.6 and earlier returned a list. [1] matplotlib#24976 (comment)
10 tasks
oscargus
approved these changes
Mar 30, 2023
rcomer
approved these changes
Mar 30, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 30, 2023
rcomer
added a commit
that referenced
this pull request
Mar 30, 2023
…580-on-v3.7.x Backport PR #25580 on branch v3.7.x (Fix return type of get_plot_commands)
ksunden
added a commit
to ksunden/matplotlib
that referenced
this pull request
Mar 30, 2023
Includes completion of rebase onto matplotlib#25580, fixing type hint
Higgs32584
pushed a commit
to Higgs32584/matplotlib
that referenced
this pull request
Apr 17, 2023
Includes completion of rebase onto matplotlib#25580, fixing type hint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The typing PR found that this was returning a generator [1], but this was an error from #24000, as 3.6 and earlier returned a list.
[1] #24976 (comment)
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst