Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use classic style in old what's new entries #25623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

haojunsong-08
Copy link
Contributor

PR Summary

This PR closes #7199
Changed 3 code example and it's plot on release 0.99
Screenshot 2023-04-04 at 15 17 52

Change from above to

Screenshot 2023-04-04 at 22 20 26

Screenshot 2023-04-04 at 22 21 11

to this:

Screenshot 2023-04-04 at 22 21 16

Screenshot 2023-04-04 at 22 22 16

to this

Screenshot 2023-04-04 at 22 22 19

Changed the release 1.1
from this
Screenshot 2023-04-04 at 22 23 14

to this:

Screenshot 2023-04-04 at 22 23 20

Changed the release 1.2
from
Screenshot 2023-04-04 at 22 25 09

to this:

Screenshot 2023-04-04 at 22 25 00

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [N/A ] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [ N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic QuLogic changed the title Doc change for issue 7199 Use classic style in old what's new entries Apr 15, 2023
@ksunden
Copy link
Member

ksunden commented May 16, 2023

The use of cm.viridis is itself anachronistic in that first example... I was surprised to see it with the classic style applied, but it is called for directly in the code (dating from #6957 (later inlined as a .. plot directive)) and is actually what caused #7199...

@anntzer thoughts?

@anntzer
Copy link
Contributor

anntzer commented May 17, 2023

FWIW I think I'd revert that part of #6957, but I can't say I feel very strongly about that issue anymore.

@jklymak jklymak merged commit d2e9603 into matplotlib:main Jun 14, 2023
@jklymak
Copy link
Member

jklymak commented Jun 14, 2023

This is good as-is. If we wish to mess with viridis or not, that can be a follow up.

@QuLogic QuLogic added this to the v3.8.0 milestone Jun 14, 2023
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Jun 15, 2023
* whatsnew 0.99 rendered with classic style

* whatsnew 1.1 rendered with classic style

* whatsnew 1.2 rendered with classic style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Old whatsnews should be rendered using classic style
6 participants